Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat NG objects inside legacy fragmentation as monolithic. #25598

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 17, 2020

And vice versa: Treat legacy objects as monolithic inside NG block
fragmentation.

The two block fragmentation implementations (NG and legacy) cannot
cooperate, so once we switch engine somewhere inside a fragmentation
context, we need to treat that subtree as monolithic.

This requires us to specify which fragmentation engine is being in use
when calling GetPaginationBreakability(), at least when possible at all.
This required some work in LayoutFlowThread and
LayoutMultiColumnFlowThread.

Bug: 1127112
Change-Id: I8e0c4d17fd8985c488614e01db23a0c63e899679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416069
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808334}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2416069 branch 2 times, most recently from b2ff607 to 69f7d0e Sep 18, 2020
And vice versa: Treat legacy objects as monolithic inside NG block
fragmentation.

The two block fragmentation implementations (NG and legacy) cannot
cooperate, so once we switch engine somewhere inside a fragmentation
context, we need to treat that subtree as monolithic.

This requires us to specify which fragmentation engine is being in use
when calling GetPaginationBreakability(), at least when possible at all.
This required some work in LayoutFlowThread and
LayoutMultiColumnFlowThread.

Bug: 1127112
Change-Id: I8e0c4d17fd8985c488614e01db23a0c63e899679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416069
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808334}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2416069 branch from 69f7d0e to 1cf430c Sep 18, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7ff7026 into master Sep 18, 2020
19 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2416069 branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants