Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to validate XR compatible request scenarios that should throw #25604

Merged
merged 1 commit into from Sep 24, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 17, 2020

This change adds tests that validate scenarios where requesting XR
compatibility should fail:

  • If the WebXR feature policy isn't allowed, a SecurityError is thrown
  • If there are no devices available, an InvalidStateError is thrown

A runtime enabled feature is added for WebXR multi GPU that syncs with
the corresponding Chromium feature flag.

Bug: 1124024
Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416856
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810288}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2416856 branch from 5e06993 to 2ccdebb Sep 24, 2020
This change adds tests that validate scenarios where requesting XR
compatibility should fail:
- If the WebXR feature policy isn't allowed, a SecurityError is thrown
- If there are no devices available, an InvalidStateError is thrown

A runtime enabled feature is added for WebXR multi GPU that syncs with
the corresponding Chromium feature flag.

Bug: 1124024
Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416856
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810288}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2416856 branch from 2ccdebb to 7e74ed5 Sep 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d1e793e into master Sep 24, 2020
27 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2416856 branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants