Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "idle-detection: Implement requestPermission() method" #25611

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 18, 2020

This reverts commit 67a8dbc31af629c51d6661c1b1d6da4218258ad8.

Reason for revert: https://crbug.com/1129639

Original change's description:

idle-detection: Implement requestPermission() method

This change implements a static requestPermission() method on the
IdleDetector interface and switches the API from requiring the
"notifications" permission to the new "idle-detector" permission.

Bug: 878979
Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808019}

TBR=reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org

Change-Id: I41401a81e0e75613340ebe8aa5665c3d1a45414c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417473
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808208}

This reverts commit 67a8dbc31af629c51d6661c1b1d6da4218258ad8.

Reason for revert: https://crbug.com/1129639

Original change's description:
> idle-detection: Implement requestPermission() method
>
> This change implements a static requestPermission() method on the
> IdleDetector interface and switches the API from requiring the
> "notifications" permission to the new "idle-detector" permission.
>
> Bug: 878979
> Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539
> Auto-Submit: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Ayu Ishii <ayui@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#808019}

TBR=reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org

Change-Id: I41401a81e0e75613340ebe8aa5665c3d1a45414c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417473
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808208}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Loading

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c52e246 into master Sep 18, 2020
19 checks passed
Loading
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-b49f79c472 branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants