Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathml] Improve feature detection for operator dictionary test #25619

Merged
merged 2 commits into from Sep 30, 2020

Conversation

@fred-wang
Copy link
Contributor

@fred-wang fred-wang commented Sep 18, 2020

The operator dictionary test compare various properties with an
explicit attribute set VS the default dictionary value. If the
feature corresponding to that property is not supported, then the
test will just return false positives. Feature detection was
implemented for spacing and movablelimits. This commit implements
the detection for the remaining properties (largeop, stretchy,
symmetric). This requires a special test font and so only
async feature detection functions are possible.

@wpt-pr-bot
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot commented Sep 18, 2020

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Loading

@fred-wang fred-wang requested a review from rwlbuis Sep 18, 2020
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25619 Sep 18, 2020 Inactive
Copy link
Contributor

@rwlbuis rwlbuis left a comment

lgtm

Loading

@fred-wang fred-wang changed the title [mathml] Improve feature detection for operator dictionnary test [mathml] Improve feature detection for operator dictionary test Sep 18, 2020
@fred-wang fred-wang closed this Sep 18, 2020
@fred-wang fred-wang reopened this Sep 18, 2020
@fred-wang fred-wang closed this Sep 22, 2020
@fred-wang fred-wang reopened this Sep 22, 2020
fred-wang added 2 commits Sep 30, 2020
The operator dictionary test compare various properties with an
explicit attribute set VS the default dictionary value. If the
feature corresponding to that property is not supported, then the
test will just return false positives. Feature detection was
implemented for spacing and movablelimits. This commit implements
the detection for the remaining properties (largeop, stretchy,
symmetric). This requires a special test font and so only
async feature detection functions are possible.
@fred-wang fred-wang force-pushed the mathml-op-dict-feature-detect branch from 591b9d1 to d09fa6e Sep 30, 2020
@fred-wang fred-wang merged commit 1918e32 into master Sep 30, 2020
20 checks passed
Loading
@fred-wang fred-wang deleted the mathml-op-dict-feature-detect branch Sep 30, 2020
ziransun added a commit to ziransun/wpt that referenced this issue Oct 6, 2020
…platform-tests#25619)

* [mathml] Improve feature detection for operator dictionnary test

The operator dictionary test compare various properties with an
explicit attribute set VS the default dictionary value. If the
feature corresponding to that property is not supported, then the
test will just return false positives. Feature detection was
implemented for spacing and movablelimits. This commit implements
the detection for the remaining properties (largeop, stretchy,
symmetric). This requires a special test font and so only
async feature detection functions are possible.

* move operator detection into a separate file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants