Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin isolation: add crash test for noopener popup windows #25636

Merged
merged 1 commit into from Sep 24, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 18, 2020

This illustrates the issue in https://crbug.com/1099718.

Bug: 1099718
Change-Id: Ie27df0a2cd5f62370332b318726bc10f965efe85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270626
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809886}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Loading

@domenic
Copy link
Member

@domenic domenic commented Sep 23, 2020

@stephenmcgruer another instance of the issue discussed in #23364, which will need manual merge.

Note that we're working on a fix for the Chrome bug in https://chromium-review.googlesource.com/c/chromium/src/+/2411423 so hopefully this shouldn't happen much longer.

Loading

This illustrates the issue in https://crbug.com/1099718.

Bug: 1099718
Change-Id: Ie27df0a2cd5f62370332b318726bc10f965efe85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270626
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809886}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2270626 branch from f0dabc2 to 0a712c6 Sep 23, 2020
@stephenmcgruer stephenmcgruer merged commit f4b94a7 into master Sep 24, 2020
20 of 22 checks passed
Loading
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-2270626 branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants