Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOP] access reporting: fix flakes reporting.html #25834

Merged
merged 1 commit into from Feb 22, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 29, 2020


The WPT testharness.js is defining:

WindowTestEnvironment.prototype._forEach_windows = function(callback) {
// Iterate over the windows [self ... top, opener]. The callback is
// passed two objects, the first one is the window object itself, the
// second one is a boolean indicating whether or not it's on the same
// origin as the (...)

This causes some postMessage to be sent cross-window. They are reported
and causes failures. For instance in reporting-observer.html test.

This patch removes testharness.js from executor.html
This fixed the issue for reporting-observer.html

More generally, we shouldn't check access in between two windows, when
one of them is using testharness.js


Second discovery:
The official web-platform-test runner sometimes drop POST requests
when many are requested in parallel. Using a lock fixes the issue.


Bug: 1090273
Change-Id: I261b9bfece935e3613c250a3a9402a1c8a6ff14e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436742
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#855712}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2436742 branch from 8a383e8 to b910212 Sep 29, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2436742 branch from b910212 to 89de933 Oct 6, 2020
@LukeZielinski LukeZielinski reopened this Oct 6, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2436742 branch 2 times, most recently from 44f8a45 to 12e875d Feb 16, 2021
@ArthurSonzogni
Copy link
Contributor

@ArthurSonzogni ArthurSonzogni commented Feb 19, 2021

I will proceed with landing this despite not passing wpt-{chrome,firefox}-dev-stability.

There was existing problems:

This patches fixes the last two ones. However it remains the first two. This is a strict improvement. Could you approve this patch?

---

The WPT testharness.js is defining:
```
WindowTestEnvironment.prototype._forEach_windows = function(callback) {
// Iterate over the windows [self ... top, opener]. The callback is
// passed two objects, the first one is the window object itself, the
// second one is a boolean indicating whether or not it's on the same
// origin as the (...)
```

This causes some postMessage to be sent cross-window. They are reported
and causes failures. For instance in reporting-observer.html test.

This patch removes testharness.js from executor.html
This fixed the issue for reporting-observer.html

More generally, we shouldn't check access in between two windows, when
one of them is using testharness.js

---

Second discovery:
The official web-platform-test runner sometimes drop POST requests
when many are requested in parallel. Using a lock fixes the issue.

---

Bug: 1090273
Change-Id: I261b9bfece935e3613c250a3a9402a1c8a6ff14e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436742
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#855712}
@KyleJu
Copy link

@KyleJu KyleJu commented Feb 19, 2021

I will proceed with landing this despite not passing wpt-{chrome,firefox}-dev-stability.

There was existing problems:

This patches fixes the last two ones. However it remains the first two. This is a strict improvement. Could you approve this patch?

Thanks for the headsup Arther! @stephenmcgruer could you admin merge?

@stephenmcgruer stephenmcgruer merged commit 9b505f9 into master Feb 22, 2021
21 of 24 checks passed
21 of 24 checks passed
update-pr-preview
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20210219.56 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-2436742 branch Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants