Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WPT test to verify the mouse click count in infrastructure/ #26480

Merged
merged 2 commits into from Nov 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 11, 2020

We should have a WPT test to verify the mouse click count, such as
double click and triple click. For the click count is greater than 3, we
should increase it when the OS is Windows and Mac, reset to 1 otherwise.
Also reset the mouse click count, if the mouse moves to a different
locations.

Bug: 1119679
Change-Id: I755c1f49a470598391440802e2ad62817a958777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515882
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830279}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2515882 branch from f0fce92 to e8b1bb9 Nov 18, 2020
We should have a WPT test to verify the mouse click count, such as
double click and triple click. For the click count is greater than 3, we
should increase it when the OS is Windows and Mac, reset to 1 otherwise.
Also reset the mouse click count, if the mouse moves to a different
locations.

Bug: 1119679
Change-Id: I755c1f49a470598391440802e2ad62817a958777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515882
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830279}
@Hexcles
Copy link
Member

@Hexcles Hexcles commented Nov 24, 2020

Looks like this failed on Firefox: https://community-tc.services.mozilla.com/tasks/AKWrpLS4Rz2GK_d-TtW5_A/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FAKWrpLS4Rz2GK_d-TtW5_A%2Fruns%2F0%2Fartifacts%2Fpublic%252Flogs%252Flive.log#L2298

  FAIL TestDriver actions: test the mouse click counts at different cases - assert_array_equals: expected property 4 to be 3 but got 1 (expected array [1, 2, 1, 2, 3] got [1, 2, 1, 2, 1])

cc @LanWei22

@Hexcles Hexcles force-pushed the chromium-export-cl-2515882 branch from 325dc6d to 529a8bd Nov 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 63e3b67 into master Nov 25, 2020
32 checks passed
32 checks passed
Azure Pipelines Build #20201125.37 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests (Python 2) Community-TC (pull_request)
Details
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
resources/ tests (Python 3.8) Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
tools/ integration tests (Python 2) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
tools/ unittests (Python 2) Community-TC (pull_request)
Details
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2515882 branch Nov 25, 2020
@jgraham
Copy link
Contributor

@jgraham jgraham commented Nov 27, 2020

It's somewhat unclear to me why this is an infrastructure test vs a wdspec test? Also what's the spec basis for the expectations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants