Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: unload-a-document tests do not respect wss variant #26586

Merged
merged 1 commit into from Nov 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 20, 2020

tests in
third_party/blink/web_tests/external/wpt/websockets/unload-a-document/
have wss variant. But when opening a popup, they don't pass the
location.search parameter to their children. So for example,
001.html?wss will 001-1.html. And since 001-1.html has no knowledge of
the wss param, it will (incorrectly) open an insecure sockets.

Because of that, tests in websockets/unload-a-document always run the
insecure variant.

This patch fixes the issue.

Bug: 801564
Change-Id: Ib88aa1c12dc6f8a390f650b164cd4cd203939a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552078
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Arnaud Renevier <arenevier@fb.com>
Cr-Commit-Position: refs/heads/master@{#830853}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2552078 branch from 0091295 to bd66b7f Nov 20, 2020
tests in
third_party/blink/web_tests/external/wpt/websockets/unload-a-document/
have wss variant. But when opening a popup, they don't pass the
location.search parameter to their children. So for example,
001.html?wss will 001-1.html. And since 001-1.html has no knowledge of
the wss param, it will (incorrectly) open an insecure sockets.

Because of that, tests in websockets/unload-a-document always run the
insecure variant.

This patch fixes the issue.

Bug: 801564
Change-Id: Ib88aa1c12dc6f8a390f650b164cd4cd203939a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552078
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Arnaud Renevier <arenevier@fb.com>
Cr-Commit-Position: refs/heads/master@{#830853}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2552078 branch from bd66b7f to 024fe53 Nov 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 03f5a82 into master Nov 25, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20201125.10 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2552078 branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants