Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annotated-spec-related functionality from canvas tests #26619

Merged
merged 3 commits into from Nov 25, 2020

Conversation

@adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Nov 23, 2020

This removes the cruft I mentioned in #26618.

I've split this into three commits:

  • The first removes current-work-canvas.xhtml and related Python script functionality.
  • The second removes the previously field from spec.yaml.
  • The third removes the <^> and <eol> syntax from the text snippets in spec.yaml. It appears that <^> was used to indicate where links to relevant tests would be inserted into the text, and <eol> was used to aid text processing. I've kept <...> as I believe it has relevant semantic meaning but I'd be open to removing it as well.
adroitwhiz added 3 commits Nov 23, 2020
The functionality to generate an annotated canvas spec was removed in
commit dadd085, but remnants of it
have been lingering in the codebase, confusing anyone who tries to make
sense of the canvas tests. This removes those remnants.
This was used for disambiguation when generating an annotated spec that
is no longer generated.
This is where links to the generated tests would be inserted in the
annotated spec, which is no longer generated.
@fserb
fserb approved these changes Nov 25, 2020
@fserb fserb merged commit cfcd8eb into web-platform-tests:master Nov 25, 2020
31 checks passed
31 checks passed
Azure Pipelines Build #20201123.37 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests (Python 2) Community-TC (pull_request)
Details
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
resources/ tests (Python 3.8) Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
tools/ integration tests (Python 2) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
tools/ unittests (Python 2) Community-TC (pull_request)
Details
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants