Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages of generate-test-{sxgs,wbns}.sh #26633

Merged
merged 1 commit into from Nov 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 24, 2020

go get installs commands in $GOPATH/bin (or ~/go/bin if $GOPATH is not
set), which may not be listed in the user's PATH environment variable.

crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/
loading/sxg/resources/generate-test-sxgs.sh, and this updates the
remaining scripts and READMEs.

Bug: 1151384
Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830883}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

`go get` installs commands in $GOPATH/bin (or ~/go/bin if $GOPATH is not
set), which may not be listed in the user's PATH environment variable.

crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/
loading/sxg/resources/generate-test-sxgs.sh, and this updates the
remaining scripts and READMEs.

Bug: 1151384
Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830883}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2557159 branch from e95b69b to 60ea67a Nov 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 93b6866 into master Nov 25, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20201125.15 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2557159 branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants