Fieldset NG: Do not miss to paint a LEGEND with position:relative and overflow:hidden #26634
+37
−0
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2556626
branch
from
8abf5bf
to
48e253a
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2556626
branch
from
48e253a
to
713759d
overflow:hidden In PaintLayerPainter, a layer bounding rectangle for a such LEGEND was incorrect, and nothing was painted if the anonymous fieldset content box has a layer. This CL fixes the issue by handling a rendered LEGEND in PaintLayer::ContainingLayer(). Bug: 1151295 Change-Id: If133d9179d8ab4c70d9b958aef61cedf547f704f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556626 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830799}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2556626
branch
from
713759d
to
91c4e2c
chromium-wpt-export-bot
merged commit 8eac1e9
into
master
23 checks passed
23 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In PaintLayerPainter, a layer bounding rectangle for a such LEGEND was
incorrect, and nothing was painted if the anonymous fieldset content
box has a layer.
This CL fixes the issue by handling a rendered LEGEND in
PaintLayer::ContainingLayer().
Bug: 1151295
Change-Id: If133d9179d8ab4c70d9b958aef61cedf547f704f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556626
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830799}