Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset NG: Do not miss to paint a LEGEND with position:relative and overflow:hidden #26634

Merged
merged 1 commit into from Nov 25, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 24, 2020

In PaintLayerPainter, a layer bounding rectangle for a such LEGEND was
incorrect, and nothing was painted if the anonymous fieldset content
box has a layer.

This CL fixes the issue by handling a rendered LEGEND in
PaintLayer::ContainingLayer().

Bug: 1151295
Change-Id: If133d9179d8ab4c70d9b958aef61cedf547f704f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556626
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830799}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2556626 branch from 8abf5bf to 48e253a Nov 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Fiedlset NG: Do not miss to paint a LEGEND with position:relative and overflow:hidden Fieldset NG: Do not miss to paint a LEGEND with position:relative and overflow:hidden Nov 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2556626 branch from 48e253a to 713759d Nov 24, 2020
overflow:hidden

In PaintLayerPainter, a layer bounding rectangle for a such LEGEND was
incorrect, and nothing was painted if the anonymous fieldset content
box has a layer.

This CL fixes the issue by handling a rendered LEGEND in
PaintLayer::ContainingLayer().

Bug: 1151295
Change-Id: If133d9179d8ab4c70d9b958aef61cedf547f704f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556626
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830799}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2556626 branch from 713759d to 91c4e2c Nov 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8eac1e9 into master Nov 25, 2020
23 checks passed
23 checks passed
Azure Pipelines Build #20201125.4 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2556626 branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants