Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LargestContentfulPaint] Fix invisible image tracking #26648

Merged
merged 1 commit into from Nov 26, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 25, 2020

In this CL we change |invisible_images_| to track not just LayoutObject
but also the ImageResourceContent, which is in line with how it is
tracked in |visible_images_| and is necessary to correctly track
background images as well as image source changes that do not impact
the LayoutObject used.

Bug: 1152846
Change-Id: I2bfa02ef0a6795b7036abecf8f1e342f39e6ea3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561270
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831333}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

In this CL we change |invisible_images_| to track not just LayoutObject
but also the ImageResourceContent, which is in line with how it is
tracked in |visible_images_| and is necessary to correctly track
background images as well as image source changes that do not impact
the LayoutObject used.

Bug: 1152846
Change-Id: I2bfa02ef0a6795b7036abecf8f1e342f39e6ea3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561270
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831333}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2561270 branch from c7d1c47 to 5ec9cd3 Nov 26, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 35e6915 into master Nov 26, 2020
23 checks passed
23 checks passed
Azure Pipelines Build #20201126.22 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2561270 branch Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants