Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add missing canvas YAML tests #26650

Open
wants to merge 1 commit into
base: master
from

Conversation

@adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Nov 25, 2020

Resolves #26647

This re-adds the missing YAML canvas tests that were accidentally removed in #24099.

I modified the original YAML-splitting script used in #24099 to merge the input YAML files instead of overwriting them, and this was the result.

I did rebuild the canvas tests, but because these sources haven't been editable, nothing changed.

@jgraham
Copy link
Contributor

@jgraham jgraham commented Nov 26, 2020

To be sure I understand: we didn't actually delete the files, just lost the ability to regenerate them from source, and that's why this change doesn't actually add any tests?

@adroitwhiz
Copy link
Contributor Author

@adroitwhiz adroitwhiz commented Nov 26, 2020

That's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants