Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLPattern: Add initial binding implementation. #26651

Merged
merged 1 commit into from Dec 2, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 25, 2020

This CL adds the initial binding for URLPattern and partially implements
the test() method. It includes some WPT tests, but will need additional
tests.

Bug: 1141510
Change-Id: Id6a0482915f74a37504cf45102d89d14373f2489
Binary-Size: Size increase is due to this CL happening to be first to use a number of abseil library bits.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545862
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832852}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2545862 branch 3 times, most recently from d1c0abc to ff9fc4e Nov 30, 2020
This CL adds the initial binding for URLPattern and partially implements
the test() method.  It includes some WPT tests, but will need additional
tests.

Bug: 1141510
Change-Id: Id6a0482915f74a37504cf45102d89d14373f2489
Binary-Size: Size increase is due to this CL happening to be first to use a number of abseil library bits.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545862
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832852}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2545862 branch from ff9fc4e to 53fd165 Dec 2, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a4ae4db into master Dec 2, 2020
22 checks passed
22 checks passed
Azure Pipelines Build #20201202.34 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2545862 branch Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants