URLPattern: Add initial binding implementation. #26651
Merged
+234
−0
Conversation
The review process for this patch is being conducted in the Chromium project. |
d1c0abc
to
ff9fc4e
This CL adds the initial binding for URLPattern and partially implements the test() method. It includes some WPT tests, but will need additional tests. Bug: 1141510 Change-Id: Id6a0482915f74a37504cf45102d89d14373f2489 Binary-Size: Size increase is due to this CL happening to be first to use a number of abseil library bits. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545862 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832852}
ff9fc4e
to
53fd165
a4ae4db
into
master
22 checks passed
22 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This CL adds the initial binding for URLPattern and partially implements
the test() method. It includes some WPT tests, but will need additional
tests.
Bug: 1141510
Change-Id: Id6a0482915f74a37504cf45102d89d14373f2489
Binary-Size: Size increase is due to this CL happening to be first to use a number of abseil library bits.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545862
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832852}