Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 white-space tests related to multi-columns container #26912

Closed
wants to merge 1 commit into from

Conversation

@TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Dec 16, 2020

css/css-text/white-space/multi-columns-ws-nowrap-001.html
css/css-text/white-space/reference/multi-columns-ws-nowrap-001-ref.html
css/css-text/white-space/multi-columns-ws-pre-001.html
css/css-text/white-space/reference/multi-columns-ws-pre-001-ref.html

These 2 tests verifies how multi-column containers handle 'white-space: pre' and 'white-space: nowrap' when involved with atomic inlines (inline-blocks and inline-tables). These 2 tests expose some implementation failures in Firefox 86, Chromium 89 and Epiphany 3.32.1.2 (WebKitGTK+ 2.30.3).

It appears that browsers treat 'column-gap: 2em' as suppressible, cancelable white spaces.

Over at my website, these files are:

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/multi-columns-ws-nowrap-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/multi-columns-ws-nowrap-001-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/multi-columns-ws-pre-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/multi-columns-ws-pre-001-ref.html

@TalbotG TalbotG requested review from frivoal and fantasai Dec 16, 2020
@TalbotG TalbotG self-assigned this Dec 16, 2020
@wpt-pr-bot wpt-pr-bot requested review from kojiishi, nox, plinss and r12a Dec 16, 2020
@TalbotG TalbotG removed the request for review from plinss Dec 16, 2020
Copy link
Contributor

@fantasai fantasai left a comment

So... as far as I can tell these tests are invalid. You're creating a series of four inline blocks in a single line box. There is no way column-gap can have an effect on this. There is only one column's worth of content, because there is only one line box, and line boxes can't break across columns. That line box happens to overflow its column to the right, into subsequent columns, but it hasn't fragmented into them.

@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented Feb 26, 2021

Okay. Understood. Closing this.

@TalbotG TalbotG closed this Feb 26, 2021
@TalbotG TalbotG deleted the TalbotG:CSS3Text-GT-PR20 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants