Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Taskcluster] Run Py3 infrastructure/ tests on Firefox as well as Chrome #27104

Closed
wants to merge 1 commit into from

Conversation

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jan 8, 2021

No description provided.

@stephenmcgruer stephenmcgruer force-pushed the smcgruer/infrastructure-py3-firefox branch from 9abb487 to d32a2fb Jan 8, 2021
@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer stephenmcgruer commented Jan 8, 2021

Two tests fail in infrastructure/ on Firefox under Py3:

Unexpected Results
------------------
/infrastructure/server/http2-websocket.sub.h2.any.html
  TIMEOUT WSS over h2 - Test timed out
  TIMEOUT /infrastructure/server/http2-websocket.sub.h2.any.html
/infrastructure/server/http2-websocket.sub.h2.any.worker.html
  TIMEOUT WSS over h2 - Test timed out
  TIMEOUT /infrastructure/server/http2-websocket.sub.h2.any.worker.html

Running one locally I see:

./wpt --py3 run --log-mach - --yes --metadata infrastructure/metadata/ --install-fonts --install-webdriver '--binary=~/firefox-nightly/firefox' firefox infrastructure/server/http2-websocket.sub.h2.any.html
...
 0:13.31 SUITE_START: web-platform-test - running 1 tests
 0:13.31 INFO Running testharness tests
 0:13.36 INFO Setting up ssl
 0:13.52 certutil Full command: /usr/bin/certutil -N -d /tmp/tmp_lkj9u2i.mozrunner -f /tmp/tmp_lkj9u2i.mozrunner/.crtdbpw
certutil b''
 0:13.69 certutil b''
 0:13.71 certutil b'\nCertificate Nickname                                         Trust Attributes\n                                                             SSL,S/MIME,JAR/XPI\n\nweb-platform-tests                                           CT,, \n'
 0:13.72 INFO Application command: /home/smcgruer/firefox-nightly/firefox --marionette about:blank -profile /tmp/tmp5348lbjp
 0:13.74 INFO Application command: /home/smcgruer/firefox-nightly/firefox --marionette about:blank -profile /tmp/tmpftxf19kn
 0:13.75 INFO Starting runner
 0:13.79 pid:13508 Full command: /home/smcgruer/firefox-nightly/firefox --marionette about:blank -profile /tmp/tmp5348lbjp
pid:13508 *** You are running in headless mode.
 0:15.61 pid:13508 JavaScript error: , line 0: uncaught exception: [fluent] Missing translations in en-CA: bookmarks-toolbar-empty-message.
 0:16.25 pid:13508 JavaScript error: , line 0: uncaught exception: undefined
 0:16.26 pid:13508 JavaScript error: , line 0: uncaught exception: undefined
 0:16.26 pid:13508 JavaScript error: , line 0: uncaught exception: undefined
 0:17.00 pid:13508 console.warn: SearchSettings: "get: No settings file exists, new profile?" (new Error("", "(unknown module)"))
 0:20.02 pid:13508 1610120942064        Marionette      INFO    Listening on port 45747
 0:20.29 pid:13508 JavaScript error: chrome://browser/content/tabbrowser.js, line 971: TypeError: can't access property "replace", docElement.dataset[("contentTitle" + dataSuffix)] is undefined
 0:20.29 TEST_START: /infrastructure/server/http2-websocket.sub.h2.any.html
 0:20.38 pid:13508 JavaScript error: chrome://browser/content/tabbrowser.js, line 971: TypeError: can't access property "replace", docElement.dataset[("contentTitle" + dataSuffix)] is undefined
 0:30.70 TEST_END: Test TIMEOUT, expected OK. Subtests passed 0/1. Unexpected 1
TIMEOUT WSS over h2 - Test timed outTIMEOUT /infrastructure/server/http2-websocket.sub.h2.any.html
 0:30.70 INFO No more tests
@stephenmcgruer stephenmcgruer marked this pull request as ready for review Jan 8, 2021
@wpt-pr-bot wpt-pr-bot requested review from jgraham and LukeZielinski Jan 8, 2021
@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer stephenmcgruer commented Jan 8, 2021

@jgraham - I'm not really sure what's going on here; I assume some Py3 bug in the websocket-over-http2 code, but I don't know where to start digging in.

Test passes in Firefox on Py2.

Test fails instantly in Chrome on Py2 or Py3 due to http2-websocket.sub.h2.any.js:3 WebSocket connection to 'wss://web-platform.test:9000/echo' failed: Error during WebSocket handshake: net::ERR_INVALID_HTTP_RESPONSE, so I assume (?) Chrome just doesn't support this.

@stephenmcgruer stephenmcgruer force-pushed the smcgruer/infrastructure-py3-firefox branch from d32a2fb to 0e77b1f Jan 11, 2021
@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer stephenmcgruer commented Jan 12, 2021

Thanks for fixing this @jgraham ! PTAL, this PR should be good to go now. The Azure Pipelines failure is unrelated.

@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer stephenmcgruer commented Jan 13, 2021

Landed in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants