Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT updates for highlight painting order (css-pseudo) #27147

Merged
merged 1 commit into from Jan 14, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 12, 2021

This patch updates four web platform tests involving CSS highlight
painting order, which should help us rework our highlight paint code
to comply with css-pseudo.

• css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html
• two manual tests, checking the relative painting order of
::selection and ::{grammar,spelling}-error overlays
• added @contenteditable/@spellcheck/@lang to test element
• added Selection#removeAllRanges call to work around API change
• replaced the grammar test sentence with a more obvious example
• rewrote most of the comments for clarity

• css/css-pseudo/highlight-painting-order.html
• new reftest, checking relative painting order of text, original
shadows, ::selection background, and ::selection shadows
• based on <https://bucket.daz.cat/work/igalia/0/3.html>

• css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html
• one manual test, one reftest, checking that text-shadow:none in
::selection suppresses all original shadows (even if multiple)
• dropped because they are no longer compliant (highlight overlays
have their own shadows, independent of the content’s shadows)

Bug: 1147859
Change-Id: I29bab589e3924778d555d96537d010dc33ed003f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843482}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2624328 branch 2 times, most recently from aba51be to ba86ed5 Jan 13, 2021
This patch updates four web platform tests involving CSS highlight
painting order, which should help us rework our highlight paint code
to comply with css-pseudo.

• css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html
    • two manual tests, checking the relative painting order of
      ::selection and ::{grammar,spelling}-error overlays
    • added @contenteditable/@spellcheck/@lang to test element
    • added Selection#removeAllRanges call to work around API change
    • replaced the grammar test sentence with a more obvious example
    • rewrote most of the comments for clarity

• css/css-pseudo/highlight-painting-order.html
    • new reftest, checking relative painting order of text, original
      shadows, ::selection background, and ::selection shadows
    • based on <https://bucket.daz.cat/work/igalia/0/3.html>

• css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html
    • one manual test, one reftest, checking that text-shadow:none in
      ::selection suppresses all original shadows (even if multiple)
    • dropped because they are no longer compliant (highlight overlays
      have their own shadows, independent of the content’s shadows)

Bug: 1147859
Change-Id: I29bab589e3924778d555d96537d010dc33ed003f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843482}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2624328 branch from ba86ed5 to a7a9265 Jan 14, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9d3e961 into master Jan 14, 2021
17 of 20 checks passed
17 of 20 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210114.36 failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2624328 branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants