Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blink: makes display lock use overflow-clip-rect when appropriate #27159

Merged
merged 1 commit into from Jan 19, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 13, 2021

Specifically, if the box has non visible overflow and
an overflow-clip-margin. Without this the overflow from
contain:paint doesn't take into the account the overflow-clip-margin,
and we may end up not painting when we should.

BUG=1157843
TEST=third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-clip-margin-007.html

Change-Id: Iba11a683f8cc1eb595ef26984c0dce38133fc760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626027
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844846}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2626027 branch 5 times, most recently from ff54188 to 5771058 Jan 13, 2021
Specifically, if the box has non visible overflow and
an overflow-clip-margin. Without this the overflow from
contain:paint doesn't take into the account the overflow-clip-margin,
and we may end up not painting when we should.

BUG=1157843
TEST=third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-clip-margin-007.html

Change-Id: Iba11a683f8cc1eb595ef26984c0dce38133fc760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626027
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844846}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2626027 branch from 5771058 to e2e5ad1 Jan 19, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 79d2deb into master Jan 19, 2021
18 of 20 checks passed
18 of 20 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210119.32 failed
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2626027 branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants