Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for backdrop filter underlapping a border #27160

Merged
merged 1 commit into from Jan 13, 2021

Commits on Jan 13, 2021

  1. Add a test for backdrop filter underlapping a border

    A recent bug [1] showed that in SkiaRenderer, it was possible for a
    backdrop-filter element to blend pixels from a neighboring (but not
    underlapping) render pass, due to some clipping issues. This test
    checks for this situation.
    
    The original bug was fixed in [2], but I verified that this test
    breaks pre-[2] (see patchset 1 of this CL).
    
    [1] https://crbug.com/1162743
    [2] https://chromium-review.googlesource.com/c/chromium/src/+/2611452
    
    Bug: 1162743
    Change-Id: I86d00d9831057ace40476d29848c11ba1b671a82
    Fixed: 1165868
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625156
    Auto-Submit: Mason Freed <masonfreed@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#843000}
    mfreed7 authored and chromium-wpt-export-bot committed Jan 13, 2021
    Copy the full SHA
    a4aba22 View commit details
    Browse the repository at this point in the history