Add a test for requestSubmit(null) #27165
Closed
Conversation
This should behave exactly as requestSubmit() behaves.
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
tkent-google and
zqzhang
| assert_true(event.cancelable); | ||
| assert_equals(event.submitter, null); | ||
| assert_true(event instanceof SubmitEvent); | ||
| }, 'firing an event named submit; form.requestSubmit(null)'); |
annevk
Jan 13, 2021
Member
This needs a different name from the test above, no? It seems this would result in a harness error.
This needs a different name from the test above, no? It seems this would result in a harness error.
rwlbuis
Jan 13, 2021
Author
Contributor
It has a different name :) I added null as parameter in the description.
It has a different name :) I added null as parameter in the description.
annevk
Jan 13, 2021
Member
If I search for this exact string, line 110 and 123 light up.
If I search for this exact string, line 110 and 123 light up.
domenic
Jan 13, 2021
Member
I think the tests are actually identical? Maybe this was already exported somehow?
I think the tests are actually identical? Maybe this was already exported somehow?
rwlbuis
Jan 14, 2021
Author
Contributor
Ah, I completely missed that somehow! It is good that this is tested, in https://bugs.webkit.org/show_bug.cgi?id=197958 we thought it was not tested. Sorry for the noise!
Ah, I completely missed that somehow! It is good that this is tested, in https://bugs.webkit.org/show_bug.cgi?id=197958 we thought it was not tested. Sorry for the noise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This should behave exactly as requestSubmit() behaves.