Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for requestSubmit(null) #27165

Closed
wants to merge 1 commit into from
Closed

Add a test for requestSubmit(null) #27165

wants to merge 1 commit into from

Conversation

@rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented Jan 13, 2021

This should behave exactly as requestSubmit() behaves.

This should behave exactly as requestSubmit() behaves.
assert_true(event.cancelable);
assert_equals(event.submitter, null);
assert_true(event instanceof SubmitEvent);
}, 'firing an event named submit; form.requestSubmit(null)');

This comment has been minimized.

@annevk

annevk Jan 13, 2021
Member

This needs a different name from the test above, no? It seems this would result in a harness error.

This comment has been minimized.

@rwlbuis

rwlbuis Jan 13, 2021
Author Contributor

It has a different name :) I added null as parameter in the description.

This comment has been minimized.

@annevk

annevk Jan 13, 2021
Member

If I search for this exact string, line 110 and 123 light up.

This comment has been minimized.

@domenic

domenic Jan 13, 2021
Member

I think the tests are actually identical? Maybe this was already exported somehow?

This comment has been minimized.

@annevk

annevk Jan 13, 2021
Member

The original was added in 61c2804...

This comment has been minimized.

@rwlbuis

rwlbuis Jan 14, 2021
Author Contributor

Ah, I completely missed that somehow! It is good that this is tested, in https://bugs.webkit.org/show_bug.cgi?id=197958 we thought it was not tested. Sorry for the noise!

@rwlbuis rwlbuis closed this Jan 14, 2021
@annevk annevk deleted the request_submit branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants