Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox][css-grid] move tests from vendor-imports #27174

Merged
merged 1 commit into from Jan 14, 2021

Conversation

@foolip
Copy link
Member

@foolip foolip commented Jan 13, 2021

Links are updated as recommended by dholbert:
#26884 (comment)

Part of #8615.

Fixes #26884.

Links are updated as recommended by dholbert:
#26884 (comment)

Part of #8615.

Fixes #26884.
@foolip
Copy link
Member Author

@foolip foolip commented Jan 13, 2021

I'm fairly sure I managed to move the tests without breaking them by comparing the number of tests and failures in these two views:
https://wpt.fyi/results/css?sha=8e78617565&label=pr_head
https://wpt.fyi/results/css/vendor-imports/mozilla/mozilla-central-reftests/align3?sha=c9bb4ac8ec&label=master

@foolip
Copy link
Member Author

@foolip foolip commented Jan 13, 2021

Note that I added the css/css-flexbox/abspos/ directory, which didn't exist before, following the pattern of css/css-grid/abspos/. If this renaming is merged, I also have a follow-up to move more existing tests in css/css-flexbox/ into this directory.

@Ms2ger
Ms2ger approved these changes Jan 14, 2021
@foolip foolip merged commit 526de41 into master Jan 14, 2021
23 of 24 checks passed
23 of 24 checks passed
update-pr-preview update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210113.45 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the foolip/vendor-imports-align branch Jan 14, 2021
foolip added a commit that referenced this pull request Jan 14, 2021
Now that a abspos/ directly exists, move additional tests that list
https://drafts.csswg.org/css-flexbox/#abspos-items as their only spec
link into this subdirectory.

Follow-up to #27174.
@foolip
Copy link
Member Author

@foolip foolip commented Jan 14, 2021

I've sent #27187 for further consolidation, but as a draft as I need to make sure I didn't break any tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment