Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Do not pause PiP video when removed from document #27185

Merged
merged 1 commit into from Jan 20, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 14, 2021

This CL makes sure video do not pause when playing in Picture-in-Picture
and subsequently removed from the Document.

Spec: w3c/picture-in-picture#99

Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a
Bug: 1167643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845100}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2627311 branch 2 times, most recently from 0e98f6a to 878f687 Jan 14, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [Picture-in-Picture] Do not pause PiP video when removed from document. [Picture-in-Picture] Do not pause PiP video when removed from document Jan 14, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2627311 branch 3 times, most recently from f904ad9 to 3f8b083 Jan 14, 2021
This CL makes sure video do not pause when playing in Picture-in-Picture
and subsequently removed from the Document.

Spec: w3c/picture-in-picture#99

Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a
Bug: 1167643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845100}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2627311 branch from 3f8b083 to 6c3dd08 Jan 20, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c021b6e into master Jan 20, 2021
16 of 19 checks passed
16 of 19 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210120.11 failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2627311 branch Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants