Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] move additional abspos tests into abspos/ #27187

Merged
merged 1 commit into from Jan 14, 2021

Conversation

@foolip
Copy link
Member

@foolip foolip commented Jan 14, 2021

Now that a abspos/ directly exists, move additional tests that list
https://drafts.csswg.org/css-flexbox/#abspos-items as their only spec
link into this subdirectory.

Follow-up to #27174.

Now that a abspos/ directly exists, move additional tests that list
https://drafts.csswg.org/css-flexbox/#abspos-items as their only spec
link into this subdirectory.

Follow-up to #27174.
@foolip
Copy link
Member Author

@foolip foolip commented Jan 14, 2021

Comparing these two views manually, I've checked that the same tests pass and fail, with precisely the same number of subtest failures:
https://wpt.fyi/results/css/css-flexbox/abspos?sha=e7959ed49f&label=pr_head
https://wpt.fyi/results/css/css-flexbox?sha=c7b6a59ca2&label=master

That gives me confidence I didn't entirely break the tests.

@foolip foolip marked this pull request as ready for review Jan 14, 2021
@foolip foolip merged commit a6cbbb4 into master Jan 14, 2021
21 of 22 checks passed
21 of 22 checks passed
update-pr-preview update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210114.40 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the foolip/flexbox-abspos branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants