Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite wpt/cookies/http-state/{general,mozilla}-tests.html #27188

Merged
merged 1 commit into from Jan 19, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 14, 2021

Note: after this CL lands, mozilla0011-test and mozilla0011-expected
will still be around. The intent is to port that with the rest of the
domain-test.html tests.

Here's a mapping from the legacy http-state/general-tests.html to their
new location (found in wpt/cookies/), which will have a cookie with
some variation of test=N in it.

0001 => Not ported. Already covered.
0002 => test=3 (attributes/expires.html)
0003 => test=4 (attributes/expires.html)
0004 => Not ported. Already covered.
0005 => test=2 (attributes/max-age.html)
0006 => test=3 (attributes/max-age.html)
0007 => test=14 (attributes/invalid.html)
0008 => test=15 (attributes/invalid.html)
0009 => Not ported. Basically the same as test=14 and 15 and otherwise
covered.
0010 => Not ported. Already covered.
0011 => test=16 (attributes/invalid.html)
0012 => test=17 (attributes/invalid.html)
0013 => test=12 (name/name.html)
0014 => testA=13 (name/name.html)
0015 => a=test14 (name/name.html)
0016 => z=test15 (name/name.html)
0017 => z=test16 (name/name.html)
0018 => test=18 (attributes/invalid.html)
0019 => test=19 (attributes/invalid.html)
0020 => test=20 (attributes/invalid.html)
0021 => test=16 (name/name.html)
0022 => test=22 (value/value.html)
0023 => test=21 (attributes/invalid.html)
0024 => test=22 (attributes/invalid.html)
0025 => test=23 (attributes/invalid.html)
0026 => test=24 (attributes/invalid.html)
0027 => test=17 (name/name.html)
0028 => test=25 (attributes/invalid.html)

Here's the mapping for http-state/mozilla-tests.html:

mozilla0001 => test=4 (attributes/max-age.html)
mozilla0002 => Not ported. Dupe of test=3 in max-age.html.
mozilla0003 => test=5 (attributes/expires.html)
mozilla0004 => Not ported. Covered by test=2 in max-age.html.
mozilla0005 => test=5 (attributes/max-age.html)
mozilla0006 => Not ported. Covered by test=2 in max-age.html (and dupe
of mozilla0004?)
mozilla0007 => Not ported. Dupe of mozilla0003.
mozilla0008 => test=6 (attributes/max-age.html)
mozilla0009 => test=7 (attributes/max-age.html)
mozilla0010 => test=8 (attributes/max-age.html)
mozilla0011 => Not ported yet, will be ported as part of Bug 1159858
mozilla0012 => test=9 (attributes/max-age.html)
mozilla0013 => test=10 (attributes/max-age.html)
mozilla0014 => Not ported. Covered by test7 in value.html
mozilla0015 => test=11a (attributes/name.html)
mozilla0016 => test=11b (attributes/name.html)
mozilla0017 => test=11c (attributes/name.html)

Bug: 1159862
Change-Id: I662c4af50289fef313ddf0c509a30ab6b24c88b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628259
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Mike Taylor <miketaylr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844801}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628259 branch 2 times, most recently from e76febb to e41c6e8 Jan 15, 2021
Note: after this CL lands, mozilla0011-test and mozilla0011-expected
will still be around. The intent is to port that with the rest of the
domain-test.html tests.

Here's a mapping from the legacy http-state/general-tests.html to their
new location (found in wpt/cookies/), which will have a cookie with
some variation of test=N in it.

0001 => Not ported. Already covered.
0002 => test=3 (attributes/expires.html)
0003 => test=4 (attributes/expires.html)
0004 => Not ported. Already covered.
0005 => test=2 (attributes/max-age.html)
0006 => test=3 (attributes/max-age.html)
0007 => test=14 (attributes/invalid.html)
0008 => test=15 (attributes/invalid.html)
0009 => Not ported. Basically the same as test=14 and 15 and otherwise
covered.
0010 => Not ported. Already covered.
0011 => test=16 (attributes/invalid.html)
0012 => test=17 (attributes/invalid.html)
0013 => test=12 (name/name.html)
0014 => testA=13 (name/name.html)
0015 => a=test14 (name/name.html)
0016 => z=test15 (name/name.html)
0017 => z=test16 (name/name.html)
0018 => test=18 (attributes/invalid.html)
0019 => test=19 (attributes/invalid.html)
0020 => test=20 (attributes/invalid.html)
0021 => test=16 (name/name.html)
0022 => test=22 (value/value.html)
0023 => test=21 (attributes/invalid.html)
0024 => test=22 (attributes/invalid.html)
0025 => test=23 (attributes/invalid.html)
0026 => test=24 (attributes/invalid.html)
0027 => test=17 (name/name.html)
0028 => test=25 (attributes/invalid.html)

Here's the mapping for  http-state/mozilla-tests.html:

mozilla0001 => test=4 (attributes/max-age.html)
mozilla0002 => Not ported. Dupe of test=3 in max-age.html.
mozilla0003 => test=5 (attributes/expires.html)
mozilla0004 => Not ported. Covered by test=2 in max-age.html.
mozilla0005 => test=5 (attributes/max-age.html)
mozilla0006 => Not ported. Covered by test=2 in max-age.html (and dupe
of mozilla0004?)
mozilla0007 => Not ported. Dupe of mozilla0003.
mozilla0008 => test=6 (attributes/max-age.html)
mozilla0009 => test=7 (attributes/max-age.html)
mozilla0010 => test=8 (attributes/max-age.html)
mozilla0011 => Not ported yet, will be ported as part of Bug 1159858
mozilla0012 => test=9 (attributes/max-age.html)
mozilla0013 => test=10 (attributes/max-age.html)
mozilla0014 => Not ported. Covered by test7 in value.html
mozilla0015 => test=11a (attributes/name.html)
mozilla0016 => test=11b (attributes/name.html)
mozilla0017 => test=11c (attributes/name.html)

Bug: 1159862
Change-Id: I662c4af50289fef313ddf0c509a30ab6b24c88b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628259
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Mike Taylor <miketaylr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844801}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628259 branch from e41c6e8 to b06de39 Jan 19, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6281159 into master Jan 19, 2021
18 of 20 checks passed
18 of 20 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210119.28 failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2628259 branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants