Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force caret-color in Forced Colors Mode #27196

Merged
merged 1 commit into from Jan 21, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2021

When Forced Colors happened at computed value time, caret-color would
pick up the forced color through currentcolor. However, now that
we are forcing colors at used value time, it appeared that caret-color
regressed since it no longer picks up the forced currentcolor.

This change adds caret-color to the properties that are adjusted in
Forced Colors Mode, and forces it to use the forced currentcolor.

I've opened a new spec issue to address this, as well as a few other
color properties that I noticed would also be affected by this:
w3c/csswg-drafts#5873

Bug: 1166392
Change-Id: I239700441ed17bfd0b33443887a0c72793843cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627779
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845398}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

When Forced Colors happened at computed value time, caret-color would
pick up the forced color through currentcolor. However, now that
we are forcing colors at used value time, it appeared that caret-color
regressed since it no longer picks up the forced currentcolor.

This change adds caret-color to the properties that are adjusted in
Forced Colors Mode, and forces it to use the forced currentcolor.

I've opened a new spec issue to address this, as well as a few other
color properties that I noticed would also be affected by this:
w3c/csswg-drafts#5873

Bug: 1166392
Change-Id: I239700441ed17bfd0b33443887a0c72793843cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627779
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845398}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2627779 branch from bb6a6dd to fabfa8a Jan 20, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c874cdd into master Jan 21, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210120.54 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2627779 branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants