Force caret-color in Forced Colors Mode #27196
Merged
+166
−0
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
When Forced Colors happened at computed value time, caret-color would pick up the forced color through currentcolor. However, now that we are forcing colors at used value time, it appeared that caret-color regressed since it no longer picks up the forced currentcolor. This change adds caret-color to the properties that are adjusted in Forced Colors Mode, and forces it to use the forced currentcolor. I've opened a new spec issue to address this, as well as a few other color properties that I noticed would also be affected by this: w3c/csswg-drafts#5873 Bug: 1166392 Change-Id: I239700441ed17bfd0b33443887a0c72793843cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627779 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845398}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2627779
branch
from
bb6a6dd
to
fabfa8a
chromium-wpt-export-bot
merged commit c874cdd
into
master
24 checks passed
24 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When Forced Colors happened at computed value time, caret-color would
pick up the forced color through currentcolor. However, now that
we are forcing colors at used value time, it appeared that caret-color
regressed since it no longer picks up the forced currentcolor.
This change adds caret-color to the properties that are adjusted in
Forced Colors Mode, and forces it to use the forced currentcolor.
I've opened a new spec issue to address this, as well as a few other
color properties that I noticed would also be affected by this:
w3c/csswg-drafts#5873
Bug: 1166392
Change-Id: I239700441ed17bfd0b33443887a0c72793843cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627779
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845398}