Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Link.scopes for SubresourceWebBundles #27198

Merged
merged 1 commit into from Jan 15, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2021

This CL introduces "scopes" attribute in <link> element for
SubresourceWebBundles feature.

https://github.com/WICG/webpackage/blob/master/explainers/subresource-loading.md#defining-the-scopes

For example, if the following link tag exists in the page,
<link
rel="webbundle"
href="https://example.com/dir/subresources.wbn"
scopes="https://example.com/dir/js/
https://example.com/dir/img/
https://example.com/dir/css/">
subresources under "/dir/js/", "/dir/img/" and "/dir/css/" will be
loaded from the web bundle "subresources.wbn".

Bug: 1082020
Change-Id: I36ab832c301f33b0d0f1b6f4fea7e871f7ce2b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615732
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843995}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2615732 branch 2 times, most recently from 1eddaba to 7b576be Jan 15, 2021
This CL introduces "scopes" attribute in <link> element for
SubresourceWebBundles feature.

https://github.com/WICG/webpackage/blob/master/explainers/subresource-loading.md#defining-the-scopes

For example, if the following link tag exists in the page,
  <link
    rel="webbundle"
    href="https://example.com/dir/subresources.wbn"
    scopes="https://example.com/dir/js/
            https://example.com/dir/img/
            https://example.com/dir/css/">
subresources under "/dir/js/", "/dir/img/" and "/dir/css/" will be
loaded from the web bundle "subresources.wbn".

Bug: 1082020
Change-Id: I36ab832c301f33b0d0f1b6f4fea7e871f7ce2b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615732
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843995}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2615732 branch from 7b576be to fccdbb5 Jan 15, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5dfb70f into master Jan 15, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210115.19 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2615732 branch Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants