Correctly pass --py2 or --py3 to some Azure Pipeline tasks #27199
Conversation
We had incorrectly assumed that all Azure Pipeline VMs had access to Python 2, but that isn't true (the Edge run VMs only have Py3 nowadays). As such, update_hosts.yml and update_manifest.yml broke on those VMs. Instead, make the pyflag a variable for those yml files and set it appropriately.
|
Infra failure on taskcluster is unrelated, see #27200 |
stephenmcgruer
merged commit 262bf7f
into
master
47 of 57 checks passed
47 of 57 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.6)
tools/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.8)
tools/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.6)
tools/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.8)
tools/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.6)
tools/wpt/ tests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.8)
tools/wpt/ tests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.6)
tools/wpt/ tests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.8)
tools/wpt/ tests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.6)
tools/wptrunner/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.8)
tools/wptrunner/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows)
tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.6)
tools/wptrunner/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.8)
tools/wptrunner/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS)
tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We had incorrectly assumed that all Azure Pipeline VMs had access to
Python 2, but that isn't true (the Edge run VMs only have Py3 nowadays).
As such, update_hosts.yml and update_manifest.yml broke on those VMs.
Instead, make the pyflag a variable for those yml files and set it
appropriately.