Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass --py2 or --py3 to some Azure Pipeline tasks #27199

Merged
merged 1 commit into from Jan 15, 2021

Conversation

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jan 15, 2021

We had incorrectly assumed that all Azure Pipeline VMs had access to
Python 2, but that isn't true (the Edge run VMs only have Py3 nowadays).
As such, update_hosts.yml and update_manifest.yml broke on those VMs.

Instead, make the pyflag a variable for those yml files and set it
appropriately.

We had incorrectly assumed that all Azure Pipeline VMs had access to
Python 2, but that isn't true (the Edge run VMs only have Py3 nowadays).
As such, update_hosts.yml and update_manifest.yml broke on those VMs.

Instead, make the pyflag a variable for those yml files and set it
appropriately.
@foolip
foolip approved these changes Jan 15, 2021
@stephenmcgruer stephenmcgruer marked this pull request as ready for review Jan 15, 2021
@wpt-pr-bot wpt-pr-bot requested review from jgraham and LukeZielinski Jan 15, 2021
@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer stephenmcgruer commented Jan 15, 2021

Infra failure on taskcluster is unrelated, see #27200

@stephenmcgruer stephenmcgruer merged commit 262bf7f into master Jan 15, 2021
47 of 57 checks passed
47 of 57 checks passed
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
build-and-publish
Details
build-and-tag
Details
infrastructure/ tests Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
Azure Pipelines (all tests: Edge Dev 1)
Details
Azure Pipelines (all tests: Edge Dev 10)
Details
Azure Pipelines (all tests: Edge Dev 3)
Details
Azure Pipelines (all tests: Edge Dev 4)
Details
Azure Pipelines (all tests: Edge Dev 5)
Details
Azure Pipelines (all tests: Edge Dev 6)
Details
Azure Pipelines (all tests: Edge Dev 8)
Details
Azure Pipelines (all tests: Edge Dev 9)
Details
Azure Pipelines Build #20210115.25 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (all tests: Edge Dev 2) all tests: Edge Dev 2 succeeded
Details
Azure Pipelines (all tests: Edge Dev 7) all tests: Edge Dev 7 succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.6) tools/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.8) tools/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.6) tools/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.8) tools/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.6) tools/wpt/ tests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.8) tools/wpt/ tests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.6) tools/wpt/ tests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.8) tools/wpt/ tests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.6) tools/wptrunner/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.8) tools/wptrunner/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.6) tools/wptrunner/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.8) tools/wptrunner/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests (Python 2) Community-TC (pull_request)
Details
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
resources/ tests (Python 3.8) Community-TC (pull_request)
Details
tools/ integration tests (Python 2) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
tools/ unittests (Python 2) Community-TC (pull_request)
Details
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt.fyi - safari[experimental] Safari results
Details
@stephenmcgruer stephenmcgruer deleted the smcgruer/fix-azure-edge-runs branch Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants