Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TablesNG] fix block size distribution over empty rows #27204

Merged
merged 1 commit into from Jan 20, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2021

Did not handle block size distribution over empty rows
correctly.
If there are empty constrained, and unconstrained rows,
distribute only over unconstrained rows.
We used to distribute over all empty rows.

Row height distribution is tricky. There is no agreement
between browsers on what the right thing to do is.
FF never grows empty rows. Chrome does not distribute
heights specified on TBODY.

Bug: 1161157
Change-Id: I7cb2fb76ef4add651c61b10dbf8dd9fa0b58db0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632154
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845035}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2632154 branch from 0828064 to fd27fd8 Jan 15, 2021
Did not handle block size distribution over empty rows
correctly.
If there are empty constrained, and unconstrained rows,
distribute only over unconstrained rows.
We used to distribute over all empty rows.

Row height distribution is tricky. There is no agreement
between browsers on what the right thing to do is.
FF never grows empty rows. Chrome does not distribute
heights specified on TBODY.

Bug: 1161157
Change-Id: I7cb2fb76ef4add651c61b10dbf8dd9fa0b58db0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632154
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845035}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2632154 branch from fd27fd8 to 76c046d Jan 20, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6c62a81 into master Jan 20, 2021
18 of 20 checks passed
18 of 20 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210120.9 failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2632154 branch Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants