Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content-visibility: Ignore layout shifts if auto lock visibility is toggled. #27205

Open
wants to merge 1 commit into
base: master
from

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2021

This patch ignores layout shifts in the frame where an auto lock switched
from being renderer to unrendered or vice versa. The reasoning for this
is that the content-visibility element is likely to change size due to
size-containment being applied. That size can, and frequenty does, shift
contents in the viewport. We rely on scroll anchoring to ensure nothing
visibly changes.

However, the position of the element does change. We prefer not to
penalize the site for this.

R=sullivan@chromium.org, skobes@chromium.org

Bug: 1164942
Change-Id: I3dc53813147f0ffeec6c6ceb4d6825042fe33a63
Reviewed-on: https://chromium-review.googlesource.com/2633688
WPT-Export-Revision: 386735a9dca6f351543ee1008a3e8a85f5706206

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

…oggled.

This patch ignores layout shifts in the frame where an auto lock switched
from being renderer to unrendered or vice versa. The reasoning for this
is that the content-visibility element is likely to change size due to
size-containment being applied. That size can, and frequenty does, shift
contents in the viewport. We rely on scroll anchoring to ensure nothing
visibly changes.

However, the position of the element does change. We prefer not to
penalize the site for this.

R=sullivan@chromium.org, skobes@chromium.org

Bug: 1164942
Change-Id: I3dc53813147f0ffeec6c6ceb4d6825042fe33a63
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2633688 branch from 5c3bfee to cee5fbe Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants