Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop-color, flood-color, and lighting-color in forced colors mode #27206

Merged
merged 1 commit into from Jan 21, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2021

When investigating CL:2627779, I had noticed a few other color
properties we weren't adjusting for in forced colors mode:
stop-color, flood-color, and lighting-color. In most cases, this
shouldn't make a difference since SVG elements are set to
'forced-color-adjust: none' by default, but I figured these would
be good to include for consistency.

Bug: 1166911
Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845474}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

When investigating CL:2627779, I had noticed a few other color
properties we weren't adjusting for in forced colors mode:
stop-color, flood-color, and lighting-color. In most cases, this
shouldn't make a difference since SVG elements are set to
'forced-color-adjust: none' by default, but I figured these would
be good to include for consistency.

Bug: 1166911
Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845474}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2633944 branch from b1b5857 to c1b1ab0 Jan 21, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e4ccc12 into master Jan 21, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210121.13 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2633944 branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants