Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests for legacy color formats to use a box, rather than text #27337

Merged
merged 6 commits into from Feb 22, 2021

Conversation

@svgeesus
Copy link
Contributor

@svgeesus svgeesus commented Jan 26, 2021

Same as the changes already made to the lab(), lch() and predefined color() tests, switch from a "test passes if this text is green" to "test passes if you see a green square and no red". This makes the colored patch easier to see and with no text anti-aliasing issues. The patch is also measurable.

svgeesus added 5 commits Jan 26, 2021
Merge upstream
@wpt-pr-bot wpt-pr-bot requested review from dbaron and tabatkins Jan 26, 2021
@svgeesus svgeesus requested review from smfr and removed request for dbaron Jan 26, 2021
@svgeesus svgeesus mentioned this pull request Feb 16, 2021
@weinig
weinig approved these changes Feb 22, 2021
@svgeesus svgeesus merged commit 0377b83 into web-platform-tests:master Feb 22, 2021
17 of 19 checks passed
17 of 19 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210127.4 was canceled
Details
Azure Pipelines (affected tests: Safari Technology Preview)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@svgeesus svgeesus deleted the svgeesus:legacy-box-not-text branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants