Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websockets/cookies: specify wpt_flags=https for wss variants #27397

Closed
wants to merge 1 commit into from

Conversation

@arenevier
Copy link
Contributor

@arenevier arenevier commented Jan 29, 2021

Right now, wss variants will fail because they are not served over
https. And an insecure page cannot set a secure cookie.

As a solution, we load those variants with wpt_flags=https. It will
force the test to be loaded over https.

006.https.html was a previous way of solving the same issue. We can now
get rid of it, and simply use 006.html with the correct variant set.

Right now, wss variants will fail because they are not served over
https. And an insecure page cannot set a secure cookie.

As a solution, we load those variants with wpt_flags=https. It will
force the test to be loaded over https.

006.https.html was a previous way of solving the same issue. We can now
get rid of it, and simply use 006.html with the correct variant set.
@wpt-pr-bot wpt-pr-bot requested review from jdm and zqzhang Jan 29, 2021
@arenevier arenevier closed this Feb 25, 2021
@arenevier arenevier deleted the arenevier:wss_cookies branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants