Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeIO: Add quota to async Blink interface #27507

Merged
merged 1 commit into from Feb 25, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 5, 2021

This CL adds a quota management system to NativeIO’s Blink
implementation. Before writing to a file (write, setLength), the
application must explicitly ask for capacity. When deleting or shrinking
files, the freed-up space is given back to the application. Capacity is
allocated per Javascript execution context.

This CL implements the support for the asynchronous methods of NativeIO.

Blink requests capacity from the browser process. Implementing the
browser side will be done in a followup CL. For now, the browser grants
any request up to 8 GiB.

The design doc for NativeIO's quota system is here:
https://docs.google.com/document/d/1wUrtCOsyH3qGwKuqLhV9AJD-bDAjAzfPL5r1GT8H4IY

Bug: 1137788
Change-Id: I9f528373b1e7f5bf45fa8070964cdc3f225d1657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2675973
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857674}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2675973 branch 17 times, most recently from a8fb3ab to 158f630 Feb 8, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2675973 branch 4 times, most recently from 7114e1f to 0761ea0 Feb 15, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2675973 branch 5 times, most recently from 2628450 to f204538 Feb 22, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2675973 branch 2 times, most recently from 4a4ef45 to 0db2826 Feb 25, 2021
This CL adds a quota management system to NativeIO’s Blink
implementation. Before writing to a file (write, setLength), the
application must explicitly ask for capacity. When deleting or shrinking
files, the freed-up space is given back to the application. Capacity is
allocated per Javascript execution context.

This CL implements the support for the asynchronous methods of NativeIO.

Blink requests capacity from the browser process. Implementing the
browser side will be done in a followup CL. For now, the browser grants
any request up to 8 GiB.

The design doc for NativeIO's quota system is here:
https://docs.google.com/document/d/1wUrtCOsyH3qGwKuqLhV9AJD-bDAjAzfPL5r1GT8H4IY

Bug: 1137788
Change-Id: I9f528373b1e7f5bf45fa8070964cdc3f225d1657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2675973
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857674}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2675973 branch from 0db2826 to f955836 Feb 25, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 16e6197 into master Feb 25, 2021
23 checks passed
23 checks passed
@github-actions
update-pr-preview
Details
@azure-pipelines
Azure Pipelines Build #20210225.51 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2675973 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants