Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT/content-security-policy] Add generated tests #27535

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 8, 2021

This CL adds generated CSP tests using
/wpt/common/security-features/tools/generate.py
under
/wpt/content-security-policy/gen/,
primarily to add comprehensive test coverage around workers.

This CL only adds tests for

  • worker-src and script-src directives
  • worker- and script-related subresource requests
  • on top-level Documents.

This CL doesn't remove manually-written tests
with similar test coverage, because it would still need
careful comparison of test coverage and
adding more test assertions in
/wpt/content-security-policy/generic/test-case.sub.js.

The failures on Chromium are about the lack of
securitypolicyviolation events due to https://crbug.com/928964.

The failures on other browsers are, as far as I briefly looked at,
about the lack of securitypolicyviolation events, or
due to unimplemented support for underlying features
like (module) SharedWorkers.

Bug: 928964, 1179832
Change-Id: Ib1b81827ab2547a6c59071b2f1a6613c9f9a32e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2681956
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857969}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2681956 branch 4 times, most recently from 8bc9d65 to bf6602a Feb 18, 2021
This CL adds generated CSP tests using
/wpt/common/security-features/tools/generate.py
under
/wpt/content-security-policy/gen/,
primarily to add comprehensive test coverage around workers.

This CL only adds tests for

- worker-src and script-src directives
- worker- and script-related subresource requests
- on top-level Documents.

This CL doesn't remove manually-written tests
with similar test coverage, because it would still need
careful comparison of test coverage and
adding more test assertions in
/wpt/content-security-policy/generic/test-case.sub.js.

The failures on Chromium are about the lack of
securitypolicyviolation events due to https://crbug.com/928964.

The failures on other browsers are, as far as I briefly looked at,
about the lack of securitypolicyviolation events, or
due to unimplemented support for underlying features
like (module) SharedWorkers.

Bug: 928964, 1179832
Change-Id: Ib1b81827ab2547a6c59071b2f1a6613c9f9a32e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2681956
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857969}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2681956 branch from bf6602a to e76abf2 Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bb97a68 into master Feb 26, 2021
24 checks passed
24 checks passed
@github-actions
update-pr-preview
Details
@github-actions
update-pr-preview
Details
@azure-pipelines
Azure Pipelines Build #20210226.13 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2681956 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants