Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridNG] Handle negative indices for out of flow items #27599

Merged
merged 1 commit into from Feb 23, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 12, 2021

As it is the case for grid items, out of flow items' indices can have
negative values. This change adds support and web tests for the
following cases:

  1. Negative indices within the grid.
  2. Either the start or end line are defined as 'auto' and the
    corresponding line is at the start or end-most line of the grid.
  3. The out of flow item attempts to create new lines with negative
    indices.
  4. Combination of positive and negative indices.
  5. Negative indices within an implicitly defined grid.

The last case is currently failing because of the different constraints
in flow and out of flow items' indices have related to ranges and sets.
This will be addressed in a follow up change.

Bug: 1045599
Change-Id: Id83db31bcbdb1ee4d5a0313fc109c1288eb12ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688802
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#856782}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2688802 branch 8 times, most recently from 42a5b17 to 8fcc3d3 Feb 16, 2021
As it is the case for grid items, out of flow items' indices can have
negative values. This change adds support and web tests for the
following cases:

1. Negative indices within the grid.
2. Either the start or end line are defined as 'auto' and the
   corresponding line is at the start or end-most line of the grid.
3. The out of flow item attempts to create new lines with negative
   indices.
4. Combination of positive and negative indices.
5. Negative indices within an implicitly defined grid.

The last case is currently failing because of the different constraints
in flow and out of flow items' indices have related to ranges and sets.
This will be addressed in a follow up change.

Bug: 1045599
Change-Id: Id83db31bcbdb1ee4d5a0313fc109c1288eb12ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688802
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#856782}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2688802 branch from 8fcc3d3 to eec2079 Feb 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1355ef5 into master Feb 23, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210223.48 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2688802 branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants