Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: update WPT for addIceCandidate(null) #27605

Merged
merged 1 commit into from Feb 24, 2021
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 12, 2021

BUG=chromium:978582

Change-Id: I4f6e93bd900ad8f5caf55143ded48280a6b26475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690791
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857066}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title webrtc: update WPT for addIceCandidate w/o arguments webrtc: update WPT for addIceCandidate(null) Feb 12, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2690791 branch 2 times, most recently from c519c79 to 6181834 Feb 12, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2690791 branch 2 times, most recently from 7b3a095 to cafd1a4 Feb 22, 2021
@fippo
Copy link
Contributor

@fippo fippo commented Feb 23, 2021

@jan-ivar /webrtc/RTCDTMFSender-ontonechange.https.html seems to flake again in FF. Not a bad flake at least

@fippo
Copy link
Contributor

@fippo fippo commented Feb 23, 2021

same flakyness as #27336 -- there is a pattern

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2690791 branch 2 times, most recently from 54174a9 to afea32a Feb 23, 2021
BUG=chromium:978582

Change-Id: I4f6e93bd900ad8f5caf55143ded48280a6b26475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690791
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857066}
@henbos
Copy link
Contributor

@henbos henbos commented Feb 24, 2021

The stability issues are believed to be existing flakes. Can we manually merge this @foolip ?

@foolip foolip merged commit 92b3b83 into master Feb 24, 2021
22 of 24 checks passed
22 of 24 checks passed
update-pr-preview
Details
update-pr-preview
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20210224.24 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@foolip foolip deleted the chromium-export-cl-2690791 branch Feb 24, 2021
@foolip
Copy link
Member

@foolip foolip commented Feb 24, 2021

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants