Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointerevents/pointerevent_iframe-touch-action-none_touch.html #27680

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 18, 2021

We got a script error when running the test
pointerevents/pointerevent_iframe-touch-action-none_touch.html on wpt
dashboard. I found out the problem is "JSON.parse", so I remove it.
https://wpt.fyi/results/pointerevents/
pointerevent_iframe-touch-action-none_touch.html?label=master&
label=experimental&aligned

The reason of the script error is there are some messages from
testdriver-complete which are not a string, they are just objects, so
JSON.parse cannot parse them.

Bug: 1163370
Change-Id: I368a0f0622606cce89b46ee4dc0a0431aef28096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702613
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857360}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2702613 branch 4 times, most recently from a7fb43a to d7a791d Feb 19, 2021
We got a script error when running the test
pointerevents/pointerevent_iframe-touch-action-none_touch.html on wpt
dashboard. I found out the problem is "JSON.parse", so I remove it.
https://wpt.fyi/results/pointerevents/
pointerevent_iframe-touch-action-none_touch.html?label=master&
label=experimental&aligned

The reason of the script error is there are some messages from
testdriver-complete which are not a string, they are just objects, so
JSON.parse cannot parse them.

Bug: 1163370
Change-Id: I368a0f0622606cce89b46ee4dc0a0431aef28096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702613
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857360}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2702613 branch from d7a791d to 55b74c5 Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 95924af into master Feb 24, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210224.67 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2702613 branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants