Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat transforms with rotation or skew as having invalid scale #27688

Merged
merged 1 commit into from Feb 23, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 18, 2021

We can calculate quite accurate scale for any transform without
perspective using gfx::ComputeTransform2dScaleComponents(), so we
can stop treating rotation and skew as having invalid scale, to make
raster scale for animations containing such transform operations
more accurate.

Bug: 1178439
Change-Id: I2a54bfd0c0da5e1107fa638966e1fe9f637582f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698487
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856867}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Don't treat rotation etc. having invalid scale Don't treat transforms with rotation or skew as having invalid scale Feb 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2698487 branch from b2d68fe to d8cf3e0 Feb 23, 2021
We can calculate quite accurate scale for any transform without
perspective using gfx::ComputeTransform2dScaleComponents(), so we
can stop treating rotation and skew as having invalid scale, to make
raster scale for animations containing such transform operations
more accurate.

Bug: 1178439
Change-Id: I2a54bfd0c0da5e1107fa638966e1fe9f637582f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698487
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856867}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2698487 branch from d8cf3e0 to b7b5bee Feb 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit be4e5fd into master Feb 23, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210223.65 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2698487 branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants