Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[advance-override] Implement the second percentage parameter #27691

Merged
merged 1 commit into from Feb 23, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 19, 2021

For upright characters in vertical text layout, the advance of a glyph
is its height instead of width, and therefore we may want a different
scale factor for overriding the advance height instead of width.

Hence, following the spec revision [1], this patch implements the
second parameter for use in upright glyphs in vertical text layout.

[1] w3c/csswg-drafts#6020

Bug: 1137633
Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856529}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2706243 branch 3 times, most recently from 9d9c43e to 5297082 Feb 22, 2021
For upright characters in vertical text layout, the advance of a glyph
is its height instead of width, and therefore we may want a different
scale factor for overriding the advance height instead of width.

Hence, following the spec revision [1], this patch implements the
second parameter for use in upright glyphs in vertical text layout.

[1] w3c/csswg-drafts#6020

Bug: 1137633
Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856529}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2706243 branch from 5297082 to 803ffad Feb 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f70aca5 into master Feb 23, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210223.3 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2706243 branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants