Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to check "Sec-Fetch-Dest: webbundle" header is present #27695

Merged
merged 1 commit into from Feb 22, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 19, 2021

A request for a bundle should have a "Sec-Fetch-Dest: webbundle"
request header with the <link>-based API.

This CL adds a test to make sure that the current implementation is
correctly sending the header.

The PR for the explainer is WICG/webpackage#626.

BUG=1149816, 1168449

Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856164}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2706327 branch from 8739759 to 9431943 Feb 19, 2021
A request for a bundle should have a "Sec-Fetch-Dest: webbundle"
request header with the <link>-based API.

This CL adds a test to make sure that the current implementation is
correctly sending the header.

The PR for the explainer is WICG/webpackage#626.

BUG=1149816, 1168449

Change-Id: I2bc85be77d45044e9362dd5b998a92743e93eaa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706327
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856164}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2706327 branch from 9431943 to f3a1385 Feb 22, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8d3bafb into master Feb 22, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210222.5 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2706327 branch Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants