Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URL] Ensure that path-only URLs do not have their paths erased by th… #27720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@karwa
Copy link

@karwa karwa commented Feb 21, 2021

…e pathname setter.

See: whatwg/url#582

@karwa
Copy link
Author

@karwa karwa commented Feb 21, 2021

The first added test (special URLs) is just documenting the status-quo, since there didn't seem to be a test for what happens if you set an empty string.

The second one shows the new behaviour I propose on adding to the standard.

@karwa karwa force-pushed the karwa:pathname-setter branch from 029cfbb to 428e307 Feb 22, 2021
Copy link
Member

@domenic domenic left a comment

Confirmed that the third test added here fails without the change and passes with it, in jsdom/whatwg-url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants