Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind-gen: Apply ToV8Traits to IDL callback function #27721

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 22, 2021

Applies ToV8Traits, a new system to convert a blink value to
a V8 value, to IDL callback function and callback interface.

Also fixes audio-encoder.any.js.
EncodedAudioChunkOutputCallback takes decoder_config as optional.
New ToV8 supports IDLOptional. If the argument for a callback function
is "missing", ToV8 returns undefined, not null.

Bug: 1172074
Change-Id: Ic63a8e4ed89f9d25b86254b1017f10374a19a8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2711748
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Canon Mukai <canonmukai@google.com>
Cr-Commit-Position: refs/heads/master@{#857026}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2711748 branch 2 times, most recently from b381679 to c3b8d40 Feb 22, 2021
Applies ToV8Traits, a new system to convert a blink value to
a V8 value, to IDL callback function and callback interface.

Also fixes audio-encoder.any.js.
EncodedAudioChunkOutputCallback takes decoder_config as optional.
New ToV8 supports IDLOptional. If the argument for a callback function
is "missing", ToV8 returns undefined, not null.

Bug: 1172074
Change-Id: Ic63a8e4ed89f9d25b86254b1017f10374a19a8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2711748
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Canon Mukai <canonmukai@google.com>
Cr-Commit-Position: refs/heads/master@{#857026}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2711748 branch from c3b8d40 to 4025163 Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c1775b5 into master Feb 24, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20210224.12 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2711748 branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants