bind-gen: Apply ToV8Traits to IDL callback function #27721
Merged
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2711748
branch
2 times, most recently
from
b381679
to
c3b8d40
Applies ToV8Traits, a new system to convert a blink value to a V8 value, to IDL callback function and callback interface. Also fixes audio-encoder.any.js. EncodedAudioChunkOutputCallback takes decoder_config as optional. New ToV8 supports IDLOptional. If the argument for a callback function is "missing", ToV8 returns undefined, not null. Bug: 1172074 Change-Id: Ic63a8e4ed89f9d25b86254b1017f10374a19a8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2711748 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#857026}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2711748
branch
from
c3b8d40
to
4025163
chromium-wpt-export-bot
merged commit c1775b5
into
master
23 checks passed
23 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Applies ToV8Traits, a new system to convert a blink value to
a V8 value, to IDL callback function and callback interface.
Also fixes audio-encoder.any.js.
EncodedAudioChunkOutputCallback takes decoder_config as optional.
New ToV8 supports IDLOptional. If the argument for a callback function
is "missing", ToV8 returns undefined, not null.
Bug: 1172074
Change-Id: Ic63a8e4ed89f9d25b86254b1017f10374a19a8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2711748
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Canon Mukai <canonmukai@google.com>
Cr-Commit-Position: refs/heads/master@{#857026}