Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AspectRatio] Take box-sizing into account in replaced element intrinsic sizing #27729

Merged
merged 1 commit into from Feb 23, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 22, 2021

Besides converting to border-box, also convert back to content-box by
subtracting the right amount of border and padding. Add a subtest to
replaced-element-032.html for this.

Bug: 1163176
Change-Id: Ie83504dc509b9c46a77657b51fc4bec2cffec761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2712582
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856790}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2712582 branch 2 times, most recently from 7624e7f to 1d1380a Feb 22, 2021
…sic sizing

Besides converting to border-box, also convert back to content-box by
subtracting the right amount of border and padding. Add a subtest to
replaced-element-032.html for this.

Bug: 1163176
Change-Id: Ie83504dc509b9c46a77657b51fc4bec2cffec761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2712582
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856790}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2712582 branch from 1d1380a to 1de5679 Feb 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cf5f6f7 into master Feb 23, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210223.47 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2712582 branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants