Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeIO: Block filenames longer that 100 characters #27731

Merged
merged 1 commit into from Feb 25, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 22, 2021

This fixes a bug where maximum filename length would be
installation-path and host configuration dependent. The proposed limit
is enough for existing partner and test cases. Depending on developer
feedback we might provide a Javascript-based solution as shown in this
document:
https://docs.google.com/document/d/1gjnHg9b0vuTul54MHAzRFfQ6T1XKdayYoGKs6Td8yuQ/edit?ts=5fc7a3ee&pli=1

Bug: 914488
Change-Id: I0b21d2144aee69b6cb82338365a3d6d419e2ca04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2712793
Commit-Queue: Emanuel Krivoy <krivoy@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857408}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2712793 branch from 9252263 to 7823c4c Feb 22, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title NativeIO: Block filenames longer that 100 chars NativeIO: Block filenames longer that 100 characters Feb 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2712793 branch 3 times, most recently from e837cd2 to 95b2e37 Feb 23, 2021
This fixes a bug where maximum filename length would be
installation-path and host configuration dependent. The proposed limit
is enough for existing partner and test cases. Depending on developer
feedback we might provide a Javascript-based solution as shown in this
document:
https://docs.google.com/document/d/1gjnHg9b0vuTul54MHAzRFfQ6T1XKdayYoGKs6Td8yuQ/edit?ts=5fc7a3ee&pli=1

Bug: 914488
Change-Id: I0b21d2144aee69b6cb82338365a3d6d419e2ca04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2712793
Commit-Queue: Emanuel Krivoy <krivoy@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857408}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2712793 branch from 95b2e37 to 5bc5704 Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d0ae73b into master Feb 25, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210224.73 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2712793 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants