Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call CheckCanStartAnimationOnCompositor at paint #27747

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 23, 2021

Note: this is for background-color animation only, not for other
properties.

When composite background-color animation, the paint stage collect
some parameters such as animated colors for the animation. If this
step is successful, then we will paint the element off the main
thread. After that, we can have CheckCanStartAnimationOnCompositor
returning false and refuse to run the background-color animation
on the compositor thread. In this case, the paint of the element
off the main thread won't work.

So in this CL, we call CheckCanStartAnimationOnCompositor during
the paint step. This ensures the consistency of the paint and
compositor animation.

Bug: 1178987
Change-Id: I737b1e290730637977bc6fcff65cab9b4651aa8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713344
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858271}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2713344 branch 5 times, most recently from 68c005e to 9fe5526 Feb 24, 2021
Note: this is for background-color animation only, not for other
properties.

When composite background-color animation, the paint stage collect
some parameters such as animated colors for the animation. If this
step is successful, then we will paint the element off the main
thread. After that, we can have CheckCanStartAnimationOnCompositor
returning false and refuse to run the background-color animation
on the compositor thread. In this case, the paint of the element
off the main thread won't work.

So in this CL, we call CheckCanStartAnimationOnCompositor during
the paint step. This ensures the consistency of the paint and
compositor animation.

Bug: 1178987
Change-Id: I737b1e290730637977bc6fcff65cab9b4651aa8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713344
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858271}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2713344 branch from 9fe5526 to 4dc7016 Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f3ab352 into master Feb 26, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210226.60 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2713344 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants