Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Paint for "new" columns created by OOFs in nested context #27749

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 23, 2021

In CL:2704649, support was added for OOF elements that fragment beyond
the last existing fragmentainer in a nested fragmentation context.
Instead of actually creating new columns for these, we add them to the
last existing column with additional inline offset.

In order for paint to work in this case, we needed to ensure that
these fragments retrieve the correct incoming break token in
NGFragmentChildIterator::UpdateSelfFromFragment().

Bug: 1079031
Change-Id: Ib6b7400a5b898431303fe56526d1abced0343a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713259
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857315}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2713259 branch from b2943c6 to b47cd52 Feb 24, 2021
In CL:2704649, support was added for OOF elements that fragment beyond
the last existing fragmentainer in a nested fragmentation context.
Instead of actually creating new columns for these, we add them to the
last existing column with additional inline offset.

In order for paint to work in this case, we needed to ensure that
these fragments retrieve the correct incoming break token in
NGFragmentChildIterator::UpdateSelfFromFragment().

Bug: 1079031
Change-Id: Ib6b7400a5b898431303fe56526d1abced0343a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713259
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857315}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2713259 branch from b47cd52 to 4fd4f98 Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 01cc059 into master Feb 24, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210224.58 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2713259 branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants