Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLPattern: Support unicode characters in group names. #27750

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 23, 2021

This CL adds support for unicode characters in group names, e.g.
:café. It allows group names to contain the same characters as
javascript identifiers. All other parts of the pattern are still
required to be ASCII for now.

This change was discussed in this spec issue:

WICG/urlpattern#46

Bug: 1141510
Change-Id: I094e23797ceebab42adbfbac992398643c2c9079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713886
Reviewed-by: Frank Tang <ftang@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858330}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2713886 branch 3 times, most recently from c68485d to b754768 Feb 23, 2021
This CL adds support for unicode characters in group names, e.g.
`:café`.  It allows group names to contain the same characters as
javascript identifiers.  All other parts of the pattern are still
required to be ASCII for now.

This change was discussed in this spec issue:

WICG/urlpattern#46

Bug: 1141510
Change-Id: I094e23797ceebab42adbfbac992398643c2c9079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713886
Reviewed-by: Frank Tang <ftang@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858330}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2713886 branch from b754768 to fbe4585 Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a0d7a88 into master Feb 26, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210226.66 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2713886 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants