Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly catch exception so that test can run to end #27752

Merged
merged 1 commit into from Feb 25, 2021
Merged

Conversation

@WeizhongX
Copy link
Contributor

@WeizhongX WeizhongX commented Feb 23, 2021

Met WebDriverException and it is not properly catched,
and cause an Assertion error in restart_runner, cause
the whole test abort early

Bug: 27751

Met WebDriverException and it is not properly catched,
and cause an Assertion error in restart_runner, cause
the whole test abort early
Bug: 27751
Copy link
Contributor

@LukeZielinski LukeZielinski left a comment

For some additional background, this happens when a new test starts and webdriver attempts to activate the newly-created window but the browser crashes in the middle of the navigation.

The effect is that the uncaught exception goes all the way out to the runner manager and aborts the test loop.

This kind of browser issue should be handled gracefully in the runner.

try:
if test.environment != self.last_environment:

This comment has been minimized.

@LukeZielinski

LukeZielinski Feb 23, 2021
Contributor

I wonder if this should be in a separate try/except block before this one, and perhaps results in an "INTERNAL-ERROR" or something? Maybe @jgraham can comment.

This comment has been minimized.

@WeizhongX

WeizhongX Feb 25, 2021
Author Contributor

Luke, if this is due to an issue at browser side, then "ERROR" is more appropriate? I tried and did not reproduce this on clank. What does "INTERNAL-ERROR" mean? thanks!

This comment has been minimized.

@jgraham

jgraham Feb 25, 2021
Contributor

I think result_from_exception will convert this into INTERNAL-ERROR and I think that's the correct result for this case (since it's an error not assoicated with the specific test code).

try:
if test.environment != self.last_environment:

This comment has been minimized.

@jgraham

jgraham Feb 25, 2021
Contributor

I think result_from_exception will convert this into INTERNAL-ERROR and I think that's the correct result for this case (since it's an error not assoicated with the specific test code).

@WeizhongX WeizhongX merged commit a177bcf into master Feb 25, 2021
36 checks passed
36 checks passed
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
build-and-publish
Details
build-and-tag
Details
Azure Pipelines Build #20210223.60 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.6) tools/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: Windows + Python 3.8) tools/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.6) tools/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/ unittests: macOS + Python 3.8) tools/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.6) tools/wpt/ tests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows + Python 3.8) tools/wpt/ tests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.6) tools/wpt/ tests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS + Python 3.8) tools/wpt/ tests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.6) tools/wptrunner/ unittests: Windows + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows + Python 3.8) tools/wptrunner/ unittests: Windows + Python 3.8 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.6) tools/wptrunner/ unittests: macOS + Python 3.6 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS + Python 3.8) tools/wptrunner/ unittests: macOS + Python 3.8 succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
resources/ tests (Python 3.8) Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt.fyi - safari[experimental] Safari results
Details
@WeizhongX WeizhongX deleted the catch_exception branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants