Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PlzDedicatedWorker: Send COEP report for worker initialization failure" #27755

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 24, 2021

This reverts commit 15a3b50680c497dd442927fb7033f852b25e0d24.

Reason for revert: crashes in RenderFrameHostImpl::CreateDedicatedWorkerHostFactory https://crbug.com/1180505

Original change's description:

PlzDedicatedWorker: Send COEP report for worker initialization failure

This CL sends COEP violation reports during the worker initialization
process.

The corresponded spec is here:
https://html.spec.whatwg.org/C/#check-a-global-object's-embedder-policy

  1. If ownerPolicy's report-only value is "require-corp" and policy's
    value is "unsafe-none", then queue a cross-origin embedder policy
    inheritance violation with response, "worker initialization", owner's
    policy's report only reporting endpoint, "reporting", and owner.
  2. Queue a cross-origin embedder policy inheritance violation with
    response, "worker initialization", owner's policy's reporting endpoint,
    "enforce", and owner.

Also adds WPT to check if the owner iframe can observe reports via
ReportingObserver API. Tests pass with PlzDedicatedWorker and fail with
non-PlzDedicatedWorker.

Bug: 1171094, 1060837
Change-Id: Ida5eab351879a6793c412dccc8b0cff38c38e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2650015
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850107}

Bug: 1171094
Bug: 1060837
Bug: 1180505
Change-Id: I2803227fa27b308cb27a6999b2d0f72cad19cf1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2717382
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857038}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

…n failure"

This reverts commit 15a3b50680c497dd442927fb7033f852b25e0d24.

Reason for revert: crashes in RenderFrameHostImpl::CreateDedicatedWorkerHostFactory https://crbug.com/1180505

Original change's description:
> PlzDedicatedWorker: Send COEP report for worker initialization failure
>
> This CL sends COEP violation reports during the worker initialization
> process.
>
> The corresponded spec is here:
> https://html.spec.whatwg.org/C/#check-a-global-object's-embedder-policy
> > 4. If ownerPolicy's report-only value is "require-corp" and policy's
> value is "unsafe-none", then queue a cross-origin embedder policy
> inheritance violation with response, "worker initialization", owner's
> policy's report only reporting endpoint, "reporting", and owner.
> > 6. Queue a cross-origin embedder policy inheritance violation with
> response, "worker initialization", owner's policy's reporting endpoint,
> "enforce", and owner.
>
> Also adds WPT to check if the owner iframe can observe reports via
> ReportingObserver API. Tests pass with PlzDedicatedWorker and fail with
> non-PlzDedicatedWorker.
>
> Bug: 1171094, 1060837
> Change-Id: Ida5eab351879a6793c412dccc8b0cff38c38e906
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2650015
> Commit-Queue: Asami Doi <asamidoi@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#850107}

Bug: 1171094
Bug: 1060837
Bug: 1180505
Change-Id: I2803227fa27b308cb27a6999b2d0f72cad19cf1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2717382
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857038}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2717382 branch from 67ac44a to 1760271 Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e062bd6 into master Feb 24, 2021
25 checks passed
25 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210224.13 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2717382 branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants