Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NG table collapsed border pixel-snapping and clipping #27765

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 24, 2021

This fixes the following issues:

  • We missed pixel-snapping of the collapsed borders.
    Add ObjectPainterBase::DrawBoxSide() which accepts IntRect instead of
    float parameters. Previously if the float parameters were not
    pixel-snapped, they would be converted to int by truncating which
    implicitly snapped to whole pixels incorrectly.

  • We missed pixel-snapping and shrinking by border outsets for the clip
    when painting background for layered table parts. Combine the clip
    logic for cell background and other table part background with
    correct pixel-snapping and clip rect, with a test.

Bug: 1180773
Change-Id: I81a967b3de08c116eed97a08e0f608a966088f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2717524
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857955}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2717524 branch 4 times, most recently from b3afc7f to 5409fb9 Feb 24, 2021
This fixes the following issues:

- We missed pixel-snapping of the collapsed borders.
  Add ObjectPainterBase::DrawBoxSide() which accepts IntRect instead of
  float parameters. Previously if the float parameters were not
  pixel-snapped, they would be converted to int by truncating which
  implicitly snapped to whole pixels incorrectly.

- We missed pixel-snapping and shrinking by border outsets for the clip
  when painting background for layered table parts. Combine the clip
  logic for cell background and other table part background with
  correct pixel-snapping and clip rect, with a test.

Bug: 1180773
Change-Id: I81a967b3de08c116eed97a08e0f608a966088f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2717524
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857955}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2717524 branch from 5409fb9 to 2ea2e7e Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e39f98f into master Feb 26, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210226.12 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2717524 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants